Add a DeployedCondition for the VirtualMachine object #82
Conversation
This change adds a conditionType for the deployment status of a virtualmachine on the infrastructure provider.
| @@ -37,6 +37,14 @@ const ( | |||
| VirtualMachineImageNotFoundReason = "VirtualMachineImageNotFound" | |||
| ) | |||
|
|
|||
| const ( | |||
| // DeployedCondition exposes the deployment status of a VirtualMachine on the infrastructure provider. | |||
| DeployedCondition ConditionType = "Deployed" | |||
There was a problem hiding this comment.
I'm not sure I understand what this means. The VM hardware deployed successfully? The virtual hardware failed? The guest customization succeeded / failed? Both? I am not sure this makes sense as-is. Let's revisit this a bit more. I don't know that aggregate conditions make sense, and we already have a guest customization condition, so is deploy separate or a superset?
There was a problem hiding this comment.
Deploy is separate, It's synonymous to Created/Create in VM operator.
guest customization is triggered in our Update path after Create/Deploy passes.
There was a problem hiding this comment.
Deploy is separate, It's synonymous to Created/Create in VM operator.
The issue is that "deploy" is vague enough to be taken multiple ways. Plus, conditions exist as a way to be more distinct than allowed by a top-level status field such as phase. So let's come up with a better word than deployed as it seems to generic and could be mistaken to mean guest customization as well.
FWIW, here is the latest community discussion around the purpose of conditions.
| DeployedCondition ConditionType = "Deployed" | ||
|
|
||
| // DeployFailedReason (Severity=Error) documents that the deployment of the VirtualMachine was not successful. | ||
| DeployFailedReason = "DeployFailed" |
This change adds a conditionType for the deployment status of a virtualmachine on
the infrastructure provider.