Prevent taskq cash due to msg.Ctx nil and ack message before delete it #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilien1010
force-pushed
the
recover-panic-scheduler-goroutine
branch
from
d31b378 to
858a0e4
Compare
lilien1010
changed the title
vmihailenco
reviewed
Nov 17, 2021
redisq/queue.go
Outdated
| stack := string(debug.Stack()) | ||
| internal.Logger.Printf("%v,panic recovered: %v,stack=%s", name, err, stack) | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's not do this. It hides the problem, not fixes it.
Panics are exceptional situations that can leave you app in a broken state. It may be better to let the app crash and restart it then to recover.
vmihailenco
reviewed
Nov 17, 2021
| // When Release a msg, ack it before we delete msg. | ||
| if err := pipe.XAck(msg.Ctx, q.stream, q.streamGroup, msg.ID).Err(); err != nil { | ||
| return err | ||
| } |
lilien1010
force-pushed
the
recover-panic-scheduler-goroutine
branch
2 times, most recently
from
97120fe to
c1e5c06
Compare
lilien1010
changed the title
prevent it from crash in some cases
lilien1010
force-pushed
the
recover-panic-scheduler-goroutine
branch
from
c1e5c06 to
819b42b
Compare
|
Thanks |
kd7lxl
added a commit
to kd7lxl/taskq
that referenced
this pull request
Oct 12, 2022
Used the same solution as vmihailenco#153
kd7lxl
added a commit
to kd7lxl/taskq
that referenced
this pull request
Oct 12, 2022
Used the same solution as vmihailenco#153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #150