You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While testing out taskq together with Redis, we found that our applications would panic, usually after a task failure, on a nil pointer dereference here in go-redis:
Evidently, ctx was nil. The traces were somewhat obscured in cluster mode because of the additional goroutines, but in non-cluster mode we saw this section:
While testing out taskq together with Redis, we found that our applications would panic, usually after a task failure, on a nil pointer dereference here in
go-redis
:Evidently,
ctx
was nil. The traces were somewhat obscured in cluster mode because of the additional goroutines, but in non-cluster mode we saw this section:It seems that
msg.Ctx
is nil here:taskq/redisq/queue.go
Line 245 in 8faa953
Indeed,
msg
is not touched much aftermsgpack
creates it. Looking at a similar part ofqueue.go
we see an explicit initialization of theCtx
field:taskq/redisq/queue.go
Lines 408 to 410 in 8faa953
Which was added in response to a nil pointer in #150. Adding a similar initialization seems to work here as well.
The text was updated successfully, but these errors were encountered: