Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how document font is set #1877

Merged
merged 3 commits into from
May 20, 2024
Merged

Fix how document font is set #1877

merged 3 commits into from
May 20, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented May 20, 2024

Summary:

Due to what appears to be a bug in Qt 5.15.3 when changing document font, this PR reverts the changes of #1842, and instead re-implements the same functionality in a more roundabout but robust way.

Related Issue(s):

Closes #1862
Closes #1875

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.4.3 milestone May 20, 2024
@vkbo vkbo merged commit f9292d6 into release May 20, 2024
9 checks passed
@vkbo vkbo deleted the fix/text_font branch May 20, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant