Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing “Application font size” causes “Document font size” to be ignored #1862

Closed
tmarplatt opened this issue May 13, 2024 · 7 comments · Fixed by #1877
Closed
Assignees
Labels
bug Issue: Something isn't working investigate Meta: Requires further investigation qt issue Issue: Upstream issue in Qt
Milestone

Comments

@tmarplatt
Copy link
Contributor

Not claiming cause and effect here, but I have reproduced this behaviour, on v2.4.1 fresh configuration and running from source:

  • In preferences, under Document Style change your font size to something non-default, like 18 pt.
  • Confirm the new document font size change in editor and viewer.
  • In preferences, under Appearance, change your application font size to something non-default, like 14 pt.
  • Restart novelWriter, load a project
  • Editor and Viewer are now showing text in a very small font, 10 pt-ish (as opposed to the 18 pt above).
  • You can force a font size “refresh” by entering the Preferences dialog and hitting “Apply” without further changes.

This does NOT reproduce when running the v2.4.1 AppImage. Font sizes are displayed as expected.

Is this maybe another old uncool PyQt version thing? I'm on 5.15.6

@tmarplatt tmarplatt added the bug Issue: Something isn't working label May 13, 2024
@vkbo
Copy link
Owner

vkbo commented May 13, 2024

I cannot reproduce this from source. I'm guessing it is font-related maybe? What font are you using?

@vkbo vkbo added the investigate Meta: Requires further investigation label May 13, 2024
@tmarplatt
Copy link
Contributor Author

On a fresh install (aka no ~/.config/novelwriter) the default selected font family, for both Application and Document style, is Ubuntu. It's also the Application font I'm using on my current config.

@vkbo
Copy link
Owner

vkbo commented May 14, 2024

Tested again with 2.4.1 on both Ubuntu 22.04 and 24.04, and still can't reproduce the problem. I noticed that the heading font doesn't rescale when changing size (until the app is restarted), so I'll fix that at least.

Edit: Added issue #1865

@vkbo
Copy link
Owner

vkbo commented May 14, 2024

Ok, so ...

  • Ubuntu 22.04 is running Qt 5.15.3
  • Ubuntu 24.04 is running Qt 5.15.13
  • My system is running Qt 5.15.8
  • AppImage is running Qt 5.15.2

So, it could very well be an issue with Qt 5.15.6 maybe.

I did make a change in 2.4.1 to only set the document default font for the editor and viewer, instead of the whole panel's font (see #1842) so maybe that triggered a bug in 5.15.6. On which OS version did you encounter 5.15.6?

@tmarplatt
Copy link
Contributor Author

tmarplatt commented May 17, 2024

On which OS version did you encounter 5.15.6?

This is Linux Mint Cinnamon 21.3, based on Ubuntu jammy, here is the pyqt package information.

Edit: To be clear, the actual Qt5 package is 5.15.3 as you mentioned. But the PyQT version is 5.15.6.

@vkbo
Copy link
Owner

vkbo commented May 17, 2024

It's the Qt5 version that generally matters. PyQt5 is just a Python wrapper. But since I cannot reproduce the problem, it's really hard to debug. I'm guessing it's a Qt issue since none of this is actually handled by novelWriter. The setting is just forwarded to Qt.

I guess the only thing I can try is to spin up a new VM ...

@vkbo
Copy link
Owner

vkbo commented May 19, 2024

I've set up a Mint 21.3 VM, and can reproduce the error there, as well as #1875. I'm pretty sure what change it's related to, and I'm also pretty sure there is a Qt bug behind it, but I'll figure out a workaround.

@vkbo vkbo added the qt issue Issue: Upstream issue in Qt label May 19, 2024
@vkbo vkbo added this to the Release 2.4.3 milestone May 19, 2024
@vkbo vkbo self-assigned this May 19, 2024
@vkbo vkbo mentioned this issue May 20, 2024
6 tasks
@vkbo vkbo linked a pull request May 20, 2024 that will close this issue
6 tasks
@vkbo vkbo closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue: Something isn't working investigate Meta: Requires further investigation qt issue Issue: Upstream issue in Qt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants