Add local build Maven profile #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2022
HeikoKlare
reviewed
Apr 1, 2022
There was a problem hiding this comment.
Looks great, thanks! I have just one question: Wouldn't it be possible to set the vitruv.*.url properties to the nightly updatesites as per default (at the POM root level) and have it overwritten by the local profile if activated? Then we could remove the nightly-update-site-* profiles.
Comment on lines
36
to
40
| <activation> | ||
| <property> | ||
| <name>!vitruv.framework.path</name> | ||
| </property> | ||
| </activation> |
There was a problem hiding this comment.
The indentation seems to be faulty for all activation blocks.
|
Thanks for the feedback. You are absolutely right, I simplified the configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a local build Maven profile as described in Vitruv#510.
Usage:
mvn clean verify -Dvitruv.framework.path='<path_to_vitruv_folder>' -Dvitruv.domains.path='<path_to_domains_folder>'Both arguments are optional, i.e. the nightly update site of the framework but the local domains repository can also be combined.