Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to use local maven build option in GitHub actions #511

Merged
merged 3 commits into from
Apr 2, 2022

Conversation

JanWittler
Copy link
Contributor

Adapts the GitHub actions to use the local Maven builds.
Closes #510

As part of this PR, the option to execute builds with local references should be documented in the Wiki.

⚠️ Requires Vitruv-Domains#115 and Vitruv-Applications#188 to be merged first ⚠️

@JanWittler JanWittler requested a review from HeikoKlare April 1, 2022 13:41
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@JanWittler
Copy link
Contributor Author

JanWittler commented Apr 1, 2022

I could need some help correctly configuring the GitHub actions. It now works somehow but as one can see I have to escape the argument for building the domain but not for building the applications which is clearly not how it should be. Escaping both or not escaping both does not work as can be seen by the build result of the previous commits.

Edit: Found out that it is necessary because the applications are run using uses: GabrielBB/xvfb-action@v1 while domains and framework are built without that. Why do we use that @HeikoKlare?

@HeikoKlare
Copy link
Contributor

We have to use the xvfb-action for both the framework and the applications because these projects contain test cases in which a non-headless Eclipse is started for which an X server is required. The domains do not require that and thus run without it.

It seems that the xvfb-run script processes the arguments in a different way than running the mvnw script plainly, so we probably need to keep these different formats for defining the paths.
At least when using the property in a local setup (i.e., on your local machine, not in GitHub Actions) this will not be an issue, as you can simply run maven also for the framework and the applications because there will be some display server already running.

@JanWittler
Copy link
Contributor Author

Thanks for clarifying that.

@JanWittler JanWittler merged commit 3b396cb into master Apr 2, 2022
@JanWittler JanWittler deleted the local-maven-build branch April 2, 2022 18:59
@JanWittler
Copy link
Contributor Author

JanWittler commented Apr 3, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add local build Maven profile
2 participants