Misc improvement to the MoveTables user guide (bis). #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is not sql, it is sh. Signed-off-by: Jean-François Gagné <[email protected]>
The local install {1} never reference the ../common path, so referencing it here is confusing. Also, the assumption in the local install {1} is that we are in ~/my-vitess-example, not in /usr/local/vitess/examples/local. Hence having the full path is more intuitive.
{1}: https://vitess.io/docs/get-started/local/
Signed-off-by: Jean-François Gagné <[email protected]>
The insert_commerce_data part of the doc did not have a helm, local and operator differentiation, but the select_commerce_data did have this. This commit makes this consistent. Signed-off-by: Jean-François Gagné <[email protected]>
The mysql client has a --execute parameter, so the echo and the pipe were not needed. Signed-off-by: Jean-François Gagné <[email protected]>
|
Deploy preview for vitess ready! Built with commit 5321e83 |
hallaroo
added a commit
to vitessio/vitess
that referenced
this pull request
Jan 4, 2021
Once vitessio/website#656 and vitessio/website#646 have been committed to adjust the Vitess docs this file should be removed as it was confirmed to be redundant to https://github.com/vitessio/vitess/blob/master/examples/common/select_commerce_data.sql.
hallaroo
approved these changes
Jan 7, 2021
hallaroo
added a commit
to vitessio/vitess
that referenced
this pull request
Jan 8, 2021
Once vitessio/website#656 and vitessio/website#646 have been committed to adjust the Vitess docs this file should be removed as it was confirmed to be redundant to https://github.com/vitessio/vitess/blob/master/examples/common/select_commerce_data.sql. Signed-off-by: hallaroo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for the 1st PR that I messed-up.
Making things more clear, consistent, and simple.