Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete select_commerce_data.sql #7245

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Delete select_commerce_data.sql #7245

merged 1 commit into from
Jan 13, 2021

Conversation

hallaroo
Copy link
Member

@hallaroo hallaroo commented Jan 4, 2021

Description

Once vitessio/website#656 and vitessio/website#646 have been committed to adjust the Vitess docs this file should be removed as it was confirmed to be redundant to https://github.com/vitessio/vitess/blob/master/examples/common/select_commerce_data.sql.

Related Issue(s)

vitessio/website#646
vitessio/website#656

Checklist

  • Should this PR be backported? No
  • Tests are not required (file deletion only no other changes)
  • Documentation was added (the related pull requests)

Impacted Areas in Vitess

Components that this PR will affect:

  • Vitess Docs
  • Operator examples

@hallaroo hallaroo requested a review from askdba January 4, 2021 16:22
@hallaroo hallaroo requested a review from sougou as a code owner January 4, 2021 16:22
@hallaroo hallaroo self-assigned this Jan 4, 2021
@hallaroo hallaroo linked an issue Jan 4, 2021 that may be closed by this pull request
Copy link
Contributor

@askdba askdba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hallaroo hallaroo requested a review from askdba January 8, 2021 15:16
@deepthi
Copy link
Member

deepthi commented Jan 8, 2021

@hallaroo we need you to fix the DCO before we can merge.

Once vitessio/website#656 and vitessio/website#646 have been committed to adjust the Vitess docs this file should be removed as it was confirmed to be redundant to https://github.com/vitessio/vitess/blob/master/examples/common/select_commerce_data.sql.

Signed-off-by: hallaroo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local and operator example not in sync.
3 participants