Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: table lifecycle #551

Merged
merged 3 commits into from
Oct 6, 2020
Merged

Documentation: table lifecycle #551

merged 3 commits into from
Oct 6, 2020

Conversation

shlomi-noach
Copy link
Contributor

This PR documents the changes in vitessio/vitess#6719 ; we coin the term "table lifecycle" instead of "managed DROP TABLE" or "lazy DROP TABLE".

@netlify
Copy link

netlify bot commented Oct 5, 2020 •
edited
Loading

Deploy preview for vitess ready!

Built with commit 815da8d

https://deploy-preview-551--vitess.netlify.app

@deepthi deepthi requested review from aquarapid and bnlandry October 6, 2020 14:41
aquarapid
aquarapid approved these changes Oct 6, 2020
View reviewed changes
Copy link
Collaborator

@aquarapid aquarapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some changes. LGTM

@shlomi-noach
rewording
815da8d 
Signed-off-by: Shlomi Noach <[email protected]>
deepthi
deepthi approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi
Copy link
Member

deepthi commented Oct 6, 2020

I'm not quite sure User Guides is the right place for this, but we will start there and re-organize if desired.

@deepthi deepthi merged commit 18c3428 into prod Oct 6, 2020
@deepthi deepthi deleted the managed-drop-table branch October 6, 2020 17:00
@bnlandry bnlandry removed their request for review October 7, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@aquarapid aquarapid aquarapid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shlomi-noach @deepthi @aquarapid