-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Managed DROP TABLE #6719
Managed DROP TABLE #6719
Conversation
This PR is now ready for review. Still TODO:
|
This PR implements most of the This PR is enough to run table garbage collection, if only the user/app know how to RENAME their table into the correct magic form. That's easy to do if you use the mechanisms |
|
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
…opper) Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
c79b814
to
d103395
Compare
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
This PR is in good shape the way I see it. It works through a table's lifecycle to eventually drop it; it only works on tables with "magic" names like It does not offer a So, this PR only introduces a new behavior for very special tables, which will be immediately put to use by #6547 . |
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
I'm ready to have this PR reviewed and merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
We can merge after the conflicts are resolved and tests pass.
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
conflicts resolved, tests pass. Per review, I'm now merging (!) |
Tracking issue: #6689
Implementing a
TableGC
(garbage collector) component as part ofTabletServer
, which periodically checks for tables in various table-drop states, transitions the tables between those states, purges data from the tables, or drops them altogether.At this time this PR is not concerned with user facing
DROP
statements.