Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Collations and Expression grammar #9075

Merged
merged 13 commits into from
Nov 22, 2021
2 changes: 0 additions & 2 deletions go/vt/sqlparser/keywords.go
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,6 @@ var keywords = []keyword{
{"no", NO},
{"none", NONE},
{"not", NOT},
//{"now", NOW},
{"no_write_to_binlog", NO_WRITE_TO_BINLOG},
{"nth_value", UNUSED},
{"ntile", UNUSED},
Expand Down Expand Up @@ -435,7 +434,6 @@ var keywords = []keyword{
{"signed", SIGNED},
{"slow", SLOW},
{"smallint", SMALLINT},
//{"sounds"m SOUNDS},
{"spatial", SPATIAL},
{"specific", UNUSED},
{"sql", SQL},
Expand Down
14 changes: 6 additions & 8 deletions go/vt/sqlparser/parse_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2757,15 +2757,13 @@ func TestSubStr(t *testing.T) {
}

func TestLoadData(t *testing.T) {
//validSQL := []string{
// "load data from s3 'x.txt'",
// "load data from s3 manifest 'x.txt'",
// "load data from s3 file 'x.txt'",
// "load data infile 'x.txt' into table 'c'",
// "load data from s3 'x.txt' into table x"}
validSQL := []string{
"select 5 between 0 and 10 between 0 and 1,(5 between 0 and 10) between 0 and 1",
ritwizsinha marked this conversation as resolved.
Show resolved Hide resolved
}
"load data from s3 'x.txt'",
"load data from s3 manifest 'x.txt'",
"load data from s3 file 'x.txt'",
"load data infile 'x.txt' into table 'c'",
"load data from s3 'x.txt' into table x"}

for _, tcase := range validSQL {
_, err := Parse(tcase)
require.NoError(t, err)
Expand Down