Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed Collations and Expression grammar #9075

Merged
merged 13 commits into from
Nov 22, 2021
Merged

Changed Collations and Expression grammar #9075

merged 13 commits into from
Nov 22, 2021

Conversation

ritwizsinha
Copy link
Contributor

@ritwizsinha ritwizsinha commented Oct 25, 2021 •
edited by GuptaManan100
Loading

Description

This PR fixed collation and expression parsing and matched them with what MySQL was doing

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@ritwizsinha ritwizsinha changed the title initial change Changed Collations and Expression grammar Oct 29, 2021
@ritwizsinha ritwizsinha added Component: Query Serving release notes Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Oct 29, 2021
@ritwizsinha ritwizsinha marked this pull request as ready for review October 29, 2021 06:33
frouioui
frouioui reviewed Oct 29, 2021
View reviewed changes
go/vt/sqlparser/keywords.go Outdated Show resolved Hide resolved
go/vt/sqlparser/keywords.go Outdated Show resolved Hide resolved
go/vt/sqlparser/parse_test.go Outdated Show resolved Hide resolved
@ritwizsinha
Removed debugging changes
3495880 
Signed-off-by: ritwizsinha <[email protected]>
GuptaManan100
GuptaManan100 requested changes Oct 29, 2021
View reviewed changes
go/vt/sqlparser/ast.go Outdated Show resolved Hide resolved
go/vt/sqlparser/ast_format.go Outdated Show resolved Hide resolved
go/vt/sqlparser/parse_test.go Show resolved Hide resolved
go/vt/sqlparser/sql.y Show resolved Hide resolved
go/vt/sqlparser/sql.y Outdated Show resolved Hide resolved
go/vt/sqlparser/sql.y Outdated Show resolved Hide resolved
go/vt/sqlparser/sql.y Outdated Show resolved Hide resolved
@ritwizsinha
Added some formatting
78c8ac5 
Signed-off-by: ritwizsinha <[email protected]>
systay
systay reviewed Nov 11, 2021
View reviewed changes
go/vt/sqlparser/ast.go Outdated Show resolved Hide resolved
@ritwizsinha ritwizsinha mentioned this pull request Nov 16, 2021
Closed
@ritwizsinha
Fixed value args parsing
7945b78 
Signed-off-by: ritwizsinha <[email protected]>
@ritwizsinha
Merged main
108742e 
Signed-off-by: ritwizsinha <[email protected]>
GuptaManan100
GuptaManan100 approved these changes Nov 22, 2021
View reviewed changes
go/vt/sqlparser/ast.go Outdated Show resolved Hide resolved
go/vt/sqlparser/ast.go Show resolved Hide resolved
@GuptaManan100 GuptaManan100 merged commit afdf017 into vitessio:main Nov 22, 2021
@ritwizsinha ritwizsinha mentioned this pull request Nov 22, 2021
Open
18 tasks
@aquarapid aquarapid mentioned this pull request Nov 22, 2021
Closed
@GuptaManan100 GuptaManan100 mentioned this pull request Mar 31, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@frouioui frouioui frouioui left review comments

@systay systay systay left review comments

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

Assignees

@GuptaManan100 GuptaManan100

Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect Handling of COLLATE
4 participants
@ritwizsinha @systay @frouioui @GuptaManan100