-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply goimports before checking make sizegen #8828
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrors Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
…al files Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
…output Signed-off-by: Florent Poinsard <[email protected]>
frouioui
force-pushed
the
fix-make-sizegen
branch
2 times, most recently
from
September 16, 2021 10:57
3ad3ca1
to
9a57c9b
Compare
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
force-pushed
the
fix-make-sizegen
branch
from
September 16, 2021 11:04
9a57c9b
to
528d66f
Compare
Signed-off-by: Florent Poinsard <[email protected]>
…quired package from E2E ci tests Signed-off-by: Florent Poinsard <[email protected]>
frouioui
force-pushed
the
fix-make-sizegen
branch
from
September 16, 2021 12:17
8d68f60
to
4dc3200
Compare
frouioui
requested review from
harshit-gangal,
rohit-nayak-ps and
systay
as code owners
September 16, 2021 13:59
GuptaManan100
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else LGTM! 🍰
Signed-off-by: Florent Poinsard <[email protected]>
GuptaManan100
approved these changes
Sep 16, 2021
vmg
approved these changes
Sep 17, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After having issues with
check_make_sizegen
due to a difference between the source file (on whichgoimports
was applied) and the file generated by Jennifer in the import statement, CI builds started failing in this pull request with the following error:To alleviate this issue, this pull request changes how the
TestFullGeneration
test compares the local and generated files. After Jennifer has generated the file, we write its content to a temporary file, executegoimports
on it, and finally, we run the comparison between the local and generated files. This ensures that we compare local files againstgoimports
'ed files. And to make sure our local files are alwaysgoimports
'ed, this pull request adds a new workflow (check_imports
) that fails if a file is notgoimports
'ed.Adding this new workflow requires the installation of
goimports
, to do that, it was necessary to upgradesetup-go
action fromv1
tov2
as explained in this issue: actions/setup-go#27.Related Issue(s)
Checklist