-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing vtorc naming convention - database #8698
Conversation
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall good, and this seems correct. However, it looks like we're now also making a distinction between primary
and source
(e.g. you've defined source_host
and source_port
).
This means we need to be careful what we call "primary" (the top, wirteable server) and what we call "source" (the immediate parent in the topology). In light of that, there's various other variables that need to be renamed "primary"->"source".
This is at your discretion, because it goes a bit sideways to the original intention of this PR; I'm mentioning this because you seem to have made the distinction in some places, so we may as well make it all the way through.
Signed-off-by: Manan Gupta <[email protected]>
Made all the requested changes @shlomi-noach |
All requested changes have been made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one suggestion:
seconds_behind_source -> replication_lag_seconds.
The rest LGTM
Signed-off-by: Manan Gupta <[email protected]>
Description
Cleanup references to master and slave in
vt/orchestrator
in the database that it usesRelated Issue(s)
Checklist