Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing vtorc naming convention - database #8698

Merged
merged 8 commits into from
Sep 4, 2021

Conversation

GuptaManan100
Copy link
Member

Description

Cleanup references to master and slave in vt/orchestrator in the database that it uses

Related Issue(s)

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, and this seems correct. However, it looks like we're now also making a distinction between primary and source (e.g. you've defined source_host and source_port).

This means we need to be careful what we call "primary" (the top, wirteable server) and what we call "source" (the immediate parent in the topology). In light of that, there's various other variables that need to be renamed "primary"->"source".

This is at your discretion, because it goes a bit sideways to the original intention of this PR; I'm mentioning this because you seem to have made the distinction in some places, so we may as well make it all the way through.

go/vt/orchestrator/db/generate_patches.go Outdated Show resolved Hide resolved
go/vt/orchestrator/db/generate_base.go Outdated Show resolved Hide resolved
go/vt/orchestrator/db/generate_base.go Outdated Show resolved Hide resolved
go/vt/orchestrator/db/generate_patches.go Outdated Show resolved Hide resolved
go/vt/orchestrator/db/generate_patches.go Outdated Show resolved Hide resolved
go/vt/orchestrator/inst/instance_dao.go Outdated Show resolved Hide resolved
go/vt/orchestrator/inst/instance_dao.go Outdated Show resolved Hide resolved
go/vt/orchestrator/inst/instance_dao.go Outdated Show resolved Hide resolved
go/vt/orchestrator/inst/instance_dao.go Outdated Show resolved Hide resolved
go/vt/orchestrator/inst/instance_dao.go Outdated Show resolved Hide resolved
@GuptaManan100
Copy link
Member Author

Made all the requested changes @shlomi-noach

@deepthi deepthi dismissed shlomi-noach’s stale review September 2, 2021 19:28

All requested changes have been made

Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one suggestion:
seconds_behind_source -> replication_lag_seconds.
The rest LGTM

@systay systay merged commit 3583421 into vitessio:main Sep 4, 2021
@systay systay deleted the naming-vtorc-backend branch September 4, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTorc Vitess Orchestrator integration Type: Internal Cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants