Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Cleanup references to master and slave in vt/orchestrator #7110

Closed
deepthi opened this issue Dec 4, 2020 · 2 comments · Fixed by #8631
Closed

Task: Cleanup references to master and slave in vt/orchestrator #7110

deepthi opened this issue Dec 4, 2020 · 2 comments · Fixed by #8631

Comments

@deepthi
Copy link
Member

deepthi commented Dec 4, 2020

There are several references in the code under vt/orchestrator. Some of them can probably be deleted outright because we don't have to worry about backwards-compatibility yet.

For example:

SlaveLagQuery                              string   // Synonym to ReplicationLagQuery

Variables, functions and parameters should be renamed.
Every occurrence should be evaluated to determine whether it can be removed. There might be exceptions like the exact text of MySQL error messages and low-level MySQL commands.

@deepthi deepthi added this to the v9.0 milestone Dec 4, 2020
@deepthi deepthi changed the title Task: Cleanup references to "slave" in vt/orchestrator Task: Cleanup references to master and slave in vt/orchestrator Dec 4, 2020
@shlomi-noach
Copy link
Contributor

I have long since removed all and any slave reference in orchestrator, with the exception of:

  • API calls (anything that supports slave also supports replica
  • API responses (any JSON output that has "slave" also has "replica" or other compatible name)
  • CLI commands (anything that supports slave also supports replica)

All the above were kept for backwards compatibility, with the advantage that no new user needs to use the word slave.

vorchestrator can break backwards compatibility and we can eliminate slave terms altogether.

I had/have no work done for removing master.

@GuptaManan100
Copy link
Member

Closing this issue, since all the required changes have been made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants