-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online DDL/VReplication: support non-UTF8 character sets #8322
Merged
shlomi-noach
merged 24 commits into
vitessio:main
from
planetscale:online-ddl-vrepl-suite-non-utf-text
Jun 16, 2021
Merged
Online DDL/VReplication: support non-UTF8 character sets #8322
shlomi-noach
merged 24 commits into
vitessio:main
from
planetscale:online-ddl-vrepl-suite-non-utf-text
Jun 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Build/CI
Component: VReplication
Type: CI/Build
labels
Jun 13, 2021
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
…r/plan ; ConvertExpr not needed Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
shlomi-noach
requested review from
harshit-gangal,
rohit-nayak-ps and
systay
as code owners
June 14, 2021 07:14
Ready for review! Notable:
Tests are good and present multiple interesting cases (from/to utf8, from/to latin1, latin1-to-latin2, nullable, ...) |
Tests added in this PR:
|
2 tasks
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Resolved conflicts having merged #8275, and cleaned up the code a bit. |
rohit-nayak-ps
approved these changes
Jun 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! lgtm
This was referenced Jun 20, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Build/CI
Component: VReplication
Type: CI/Build
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Supporting non UTF8 character sets in OnlineDDL/VReplication:
latin1
tolatin2
)Implementation:
VReplication's filter->rule now has a new field,
CharsetConversion
, which tells Vreplication:VReplication plan will programmatically convert binlog text values according to the above.
VCopier adds a
convert(<column> using utf8mb4)
to any textual column where charset/collation has changedVStreamer identifies the
convert()
function and similarly runs aconvert(... using utf8mb4)
on same column as VCopier hinted, so that we convert the columns on the source sideRelated Issue(s)
Checklist
Notes
Submitting code changes with a lot of commented code and with debug info, as
draft pull request
. Will clean it up before making it ready for review.