-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online DDL/Vreplication suite: support ENUM->VARCHAR/TEXT type change #8275
Online DDL/Vreplication suite: support ENUM->VARCHAR/TEXT type change #8275
Conversation
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
…mapping Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
This is now ready to review. Noteworthy:
|
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Hmmm, I just added a new complex test: |
Converting back to draft while checking the new test |
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Signed-off-by: Shlomi Noach <[email protected]>
Ready for review, final. Fixed the issue failing the added test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Description
This is a difficult one to solve and this PR is not ready yet.solved.See github/gh-ost#642 for issue description in
gh-ost
and see openark/gh-ost#18 forgh-ost
solution.When the user converts a column's type from from
ENUM
toVARCHAR
they expect the new column to contain the textual representation of theenum
value. And that's what happens for rows copied viaVCopier
. ButVPlayer
copies the numeric value.Problem is
VPlayer
(or table plan builder) do not have the information about what theenum
looks like. WIP.Related Issue(s)
#8181
Checklist
Deployment Notes