Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly initialize statsTabletTypeCounts during startup #7390

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Jan 27, 2021

Description

Similar to #6989, we should update the counter for TabletType during startup

Related Issue(s)

Fixes #7389
#6988

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication
  • Cluster Management
  • Build/CI
  • VTAdmin

@deepthi deepthi requested a review from shlomi-noach as a code owner January 27, 2021 02:58
@deepthi deepthi requested review from sougou, dweitzman and rafael and removed request for shlomi-noach January 27, 2021 02:58
@deepthi
Copy link
Member Author

deepthi commented Jan 27, 2021

Since this is an off-by-1 error, we may not need to backport to older releases.
I'm willing to backport if others disagree with this.

Copy link
Member

@rafael rafael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepthi deepthi merged commit 4fea10e into vitessio:master Jan 27, 2021
@deepthi deepthi deleted the ds-ttype-counts branch January 27, 2021 23:10
@askdba askdba added this to the v10.0 milestone Feb 8, 2021
@deepthi deepthi changed the title Add 1 to statsTabletTypeCounts during startup Correctly initialize statsTabletTypeCounts during startup Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: TabletTypeCount is not incremented during tablet startup
3 participants