Correctly initialize the TabletType stats #6989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted to a draft because I noticed in testing that a tablet can still have the wrong |
dweitzman
force-pushed
the
fix_statsTabletType
branch
from
d04f58f to
78481aa
Compare
|
Fixed to set the initial stat after checkMastership runs |
deepthi
reviewed
Nov 5, 2020
| @@ -283,6 +283,7 @@ func (tm *TabletManager) Start(tablet *topodatapb.Tablet, healthCheckInterval ti | |||
|
|
|||
| // The following initializations don't need to be done | |||
| // in any specific order. | |||
| statsTabletType.Set(topoproto.TabletTypeLString(tm.tmState.tablet.Type)) | |||
There was a problem hiding this comment.
Won't it be better to do this inside exportStats? Similar to how we are setting keyspace and shard stats.
There was a problem hiding this comment.
That makes a lot of sense to me. Updated
Fixes vitessio#6988 Signed-off-by: David Weitzman <[email protected]>
dweitzman
force-pushed
the
fix_statsTabletType
branch
from
78481aa to
060bc8e
Compare
sougou
approved these changes
Nov 6, 2020
|
We should backport this to 7.0 and 8.0. Also |
This was referenced Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6988
Signed-off-by: David Weitzman [email protected]