Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtctl: Add missing err checks for VReplication v2 #7361

Merged
merged 1 commit into from
Jan 24, 2021
Merged

vtctl: Add missing err checks for VReplication v2 #7361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions go/vt/vtctl/vtctl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2001,6 +2001,7 @@ func commandVRWorkflow(ctx context.Context, wr *wrangler.Wrangler, subFlags *fla
_, err = wr.TopoServer().GetKeyspace(ctx, target)
if err != nil {
wr.Logger().Errorf("keyspace %s not found", target)
return err
}

vrwp := &wrangler.VReplicationWorkflowParams{
Expand Down Expand Up @@ -2057,6 +2058,11 @@ func commandVRWorkflow(ctx context.Context, wr *wrangler.Wrangler, subFlags *fla
if *sourceKeyspace == "" {
return fmt.Errorf("source keyspace is not specified")
}
_, err := wr.TopoServer().GetKeyspace(ctx, *sourceKeyspace)
if err != nil {
wr.Logger().Errorf("keyspace %s not found", *sourceKeyspace)
return err
}
if !*allTables && *tables == "" {
return fmt.Errorf("no tables specified to move")
}
Expand Down