Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtctl: Add missing err checks for VReplication v2 #7361

Merged
merged 1 commit into from
Jan 24, 2021
Merged

vtctl: Add missing err checks for VReplication v2 #7361

merged 1 commit into from
Jan 24, 2021

Conversation

jmoldow
Copy link
Contributor

@jmoldow jmoldow commented Jan 23, 2021

Return error immediately if the target keyspace is unknown. Do
the same for the source keyspace. Currently, the code will
attempt to continue with a bad keyspace name.

Signed-off-by: Jordan Moldow [email protected]

Related Issue(s)

Checklist

  • Should this PR be backported? - Though not required, it would be nice to include this in v9.0.0 along with the rest of the v2 VReplication changes.
  • Tests were added or are not required - Looking for feedback on this.
  • Documentation was added or is not required - Not required

Deployment Notes

Impacted Areas in Vitess

Components that this PR will affect:

  • Query Serving
  • VReplication - Only vtctl input validation
  • Cluster Management
  • Build
  • VTAdmin

Return error immediately if the target keyspace is unknown. Do
the same for the source keyspace. Currently, the code will
attempt to continue with a bad keyspace name.

Signed-off-by: Jordan Moldow <[email protected]>
@jmoldow jmoldow requested review from ajm188 and doeg as code owners January 23, 2021 23:51
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deepthi
Copy link
Member

deepthi commented Jan 24, 2021

@jmoldow thank you for catching this. It has been backported to 9.0 and will be included in the release.

@jmoldow jmoldow deleted the vreplication-v2-vtctl-err-checks branch January 24, 2021 20:57
@askdba askdba added this to the v9.0 milestone Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants