Vtctld Workflow command: minor fixes #7008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
|
@PrismaPhonic, there is a breaking change: you will need to call wr.ListActiveWorkflows() instead of wr.ListAllWorkflows() in PSDB Sharding Workflows when you use a Vitess distro after this is merged. Also please check that any other change in this PR will not impact you. |
|
Wouldn't this result in also revealing potentially a large number of FROZEN workflows that never got cleaned up? |
Yes, it will be useful to get users to cleanup their frozen workflows as a best practice. Users have also begun to use Workflow Delete to cleanup, so in general we should not have a lot of FROZEN workflows in any case. |
This was referenced Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow ListAll now includes stopped workflows. It was implemented to only give the active workflows as per PSDB's requirement. However this is confusing for regular users who don't see a created workflow if streams are in Stopped state.
Also improved output for ListAll: in particular, when there are no workflows an explicit message is provided instead of nothing
If an invalid workflow name is provided Workflow Show now errors out (earlier an inconsistent output was shown)
Signed-off-by: Rohit Nayak [email protected]