Remove vtqueryserver #5583
Merged
Remove vtqueryserver #5583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morgan Tocker <[email protected]>
|
Kill it |
|
cc @demmer |
|
Need to resolve conflicts. |
…erver Signed-off-by: Morgan Tocker <[email protected]>
|
👍 I'm ok to remove this. It was an interesting experiment originally, but I agree it's not worth the code bloat to keep it around. If a use case comes up again we can resurrect. |
sougou
approved these changes
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5531
This PR proposes that we remove vtqueryserver, which per this discussion is not being used.
The tool was never documented on vitess.io, so my understanding is that there is no current usage. But if reviewers feel otherwise, I am happy to change the PR to remove the tests and then add a note to the 5.0 release notes saying it is deprecated.
The motivation for removing this, is that it was failing unit test when using MariaDB as the mysql flavor. It is not the only test that breaks, but it is easier to remove rather than fix it. I originally had this in the PR #5559 ; but have now forked it to a separate PR.
Signed-off-by: Morgan Tocker [email protected]