Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matrix build for unit tests #5559

Merged
merged 13 commits into from
Dec 19, 2019
Merged

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Dec 12, 2019

Part of #4989

Changes:

  • Disable local_example for macOS for now (it is flaky when starting tablets. I looked into it, it's non-obvious. I will fix it by switching the vttablet-up.sh script to be init-style, and have a retry on start.)
  • Revert a previous workaround for GitHub actions instability, as it is no longer required Improve Test Stability #5567
  • Change checkout action to v2 (faster; only does a shallow checkout)
  • Add matrix build for MySQL 5.7 and MySQL 8.0. Plumbing exists for percona 5.6, MariaDB 10.1-10.3, but disabled due to disabled due to Failing Unit Test: vitess.io/vitess/go/mysql with MariaDB 10.2, 10.3 #5569 and Failing Unit Test: vt/vttablet/tabletserver/vstreamer on MySQL 5.6 and MariaDB 10.1 #5571
  • Move flaky tests to _flaky.
  • Disable go test cache (count=1). It can lead to unreliable results when testing multiple MySQL's locally since modifying environment variables does not purge cache.
  • Re-enable unit race, since we now have better handling with flaky tests. Fix unit_race so that it is maintained, but move it to run never.

Signed-off-by: Morgan Tocker [email protected]

Signed-off-by: Morgan Tocker <[email protected]>
@morgo morgo requested a review from sougou as a code owner December 12, 2019 20:56
@morgo morgo force-pushed the morgo-matrix-unit branch 12 times, most recently from 8efc522 to 63cdfd0 Compare December 13, 2019 19:29
@morgo morgo changed the title Add matrix build for unit tests Remove vtqueryserver, add matrix build for unit tests Dec 13, 2019
@morgo morgo force-pushed the morgo-matrix-unit branch from 63cdfd0 to 309bf1a Compare December 13, 2019 19:38
@morgo morgo force-pushed the morgo-matrix-unit branch from 309bf1a to e6a7e4a Compare December 13, 2019 19:53
Re-enable unit race
Change CI git checkout to be v2.0
Disable test caching

Signed-off-by: Morgan Tocker <[email protected]>
@morgo morgo changed the title Remove vtqueryserver, add matrix build for unit tests Add matrix build for unit tests Dec 17, 2019
@morgo morgo mentioned this pull request Dec 17, 2019
@morgo morgo force-pushed the morgo-matrix-unit branch from d016fe3 to 1e4c739 Compare December 17, 2019 20:24
Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
@morgo morgo requested a review from enisoc December 18, 2019 15:53
Copy link
Member

@enisoc enisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morgo morgo merged commit ca6730d into vitessio:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants