migrater: handle tables based on the vschema info #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sugu Sougoumarane <[email protected]>
Signed-off-by: Sugu Sougoumarane <[email protected]>
deepthi
approved these changes
Oct 18, 2019
| Exprs: sqlparser.SelectExprs{ | ||
| &sqlparser.AliasedExpr{Expr: &sqlparser.ColName{Name: vtable.ColumnVindexes[0].Columns[0]}}, | ||
| &sqlparser.AliasedExpr{Expr: sqlparser.NewStrVal([]byte(vtable.ColumnVindexes[0].Type))}, | ||
| &sqlparser.AliasedExpr{Expr: sqlparser.NewStrVal([]byte("{{.}}"))}, |
There was a problem hiding this comment.
Can you add some comments about the use of {{.}}?
Signed-off-by: Sugu Sougoumarane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous method of identifying reference tables was not completely reliable: it used the absence of a keyrange constraint in the filtering rules. However, this may not be the case if a target keyspace is being converted from unsharded to sharded.
The new way to identify reference tables is by looking at the vschema. This is a more unambiguous way of identifying such tables.