Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Slack sync upstream 2019 12 11.r0 #143

Merged
merged 308 commits into from
Dec 11, 2019
Merged

Conversation

rafael
Copy link

@rafael rafael commented Dec 11, 2019

Vitess continues to move fast! More than 300 commits since our last sync a month ago. Luckily many of them are general improvements in the code base. Only a few that I marked as risky.

Risky Changes

Slack changes

Other Changes

Docs / Tooling / Tests

arindamnayak and others added 30 commits November 8, 2019 11:40

Verified

This commit was signed with the committer’s verified signature.
marmarek Marek Marczykowski-Górecki
… by github workflow

Signed-off-by: Arindam Nayak <[email protected]>
Make the booststrap.sh install correct chromedriver for aarch64

Change-Id: Iefa98ed7918725f00fb8db131cae12383c44c42e
Signed-off-by: Jiamei.Xie <[email protected]>
Fix chromedriver dependency issue for aarch64.
java: Bump SNAPSHOT version to 4.1-SNAPSHOT after Vitess release 4.0
Signed-off-by: Morgan Tocker <[email protected]>
While working on filePos flavor, I encountered this issue where
an "other" statement will cause the next GTID to not be immediately
sent. This can cause delays if the target waits for that event.

This is pretty rare for GTID mode. But will likely be more pronounced
for filePos. So, I'm proactively making this fix to make sure we
don't delay sending of GTIDs, even in the case of non-relevant events.

Because of this change, this also means that we don't have to generate
pseudo-gtids. Generating GTIDs outside of transactions, coupled with
OTHER event will make the right thing happen.

Signed-off-by: Sugu Sougoumarane <[email protected]>
usage

compare to one copy per mysql connect previously

Signed-off-by: Yun Lai <[email protected]>
Add Flavor as a conn param.
Add code to handle flavor-specific GTID.

Signed-off-by: Sugu Sougoumarane <[email protected]>
In this scheme, the filePos reader detects whether we are in a
transaction or not, and emits appropriate GTID events.

Signed-off-by: Sugu Sougoumarane <[email protected]>
The vstreamer sent GTIDs "as they came". With the new change,
GTIDs are sent only when they matter: on COMMIT, DDL or OTHER.

This new approach makes the protocol easier to understand. Also,
it makes it easier for filePos to continuously send file and position.
The correct values will get used when significant events like
COMMIT are encountered.

Signed-off-by: Sugu Sougoumarane <[email protected]>
Signed-off-by: Maxim Krasilnikov <[email protected]>
Signed-off-by: Maxim Krasilnikov <[email protected]>
The vplayer currently uses ambiguous rules about how it handles the case
where a stop position was exceeded. As part of this change, we'll
standardize on: A stop position is considered to be successfully reached
if the new position is greater than or equal to the specified position.
The main motivation for this change is that the possibility of
position mismatch is higher in the case of file:pos tracking. We're
likely to hit many false positives if we're too strict.

Signed-off-by: Sugu Sougoumarane <[email protected]>
Signed-off-by: Sugu Sougoumarane <[email protected]>
Signed-off-by: Sugu Sougoumarane <[email protected]>
etcd on unstable or unsupported architectures will print a warning message and immediately exit if the environment variable ETCD_UNSUPPORTED_ARCH is not set to the target architecture.

Change-Id: Ifdd3ed4ae322484477d2db3e2d0eed09e086518f
Signed-off-by: Jiamei.Xie <[email protected]>
Eliminate that it isn't transient state causing it to fail.

Signed-off-by: Morgan Tocker <[email protected]>
arindamnayak and others added 27 commits December 10, 2019 13:21
* converted vtctld_test.py to go

Signed-off-by: Arindam Nayak <[email protected]>
Signed-off-by: Arindam Nayak <[email protected]>
* migrated one of testcase from schema.py to schema_test.go

Signed-off-by: Arindam Nayak <[email protected]>
Signed-off-by: Arindam Nayak <[email protected]>
* converted tabletmanager test cases to go

Signed-off-by: Ajeet jain <[email protected]>

Signed-off-by: Arindam Nayak <[email protected]>
* ported testcase of keyspace_test.py

Signed-off-by: Arindam Nayak <[email protected]>
Signed-off-by: Arindam Nayak <[email protected]>
* Converted sharded test from py to go

Signed-off-by: Arindam Nayak <[email protected]>
Signed-off-by: Arindam Nayak <[email protected]>
Signed-off-by: saurabh <[email protected]>
Signed-off-by: Arindam Nayak <[email protected]>
Signed-off-by: saurabh <[email protected]>
Signed-off-by: Arindam Nayak <[email protected]>
TabletManager remaining test cases in GO
Signed-off-by: Ajeet jain <[email protected]>
Signed-off-by: Arindam Nayak <[email protected]>
* moved sql start to non-blocking mode

Signed-off-by: Arindam Nayak <[email protected]>
Signed-off-by: Arindam Nayak <[email protected]>
Signed-off-by: Ajeet jain <[email protected]>

* readme for go endtoend test cases

Signed-off-by: Ajeet jain <[email protected]>

* Update README.md

Signed-off-by: Arindam Nayak <[email protected]>
Signed-off-by: Arindam Nayak <[email protected]>
EndtoEnd test cases in Go migrated from Python
Signed-off-by: Morgan Tocker <[email protected]>
Minor spelling/grammar improvements

Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
Signed-off-by: Morgan Tocker <[email protected]>
This allows bootstrap to eventually be deprecated.

Signed-off-by: Morgan Tocker <[email protected]>
…kging

Make packages with cut down binaries list
…dency-chk

Add better dependency checking
@rafael rafael merged commit 3d61060 into master Dec 11, 2019
@rafael rafael deleted the slack-sync-upstream-2019-12-11.r0 branch December 11, 2019 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.