Split tests into unit and endtoend #5304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: deepthi <[email protected]>
systay
reviewed
Oct 15, 2019
| packages_with_tests=$(go list -f '{{if len .TestGoFiles}}{{.ImportPath}} {{join .TestGoFiles " "}}{{end}}' ./go/.../endtoend/... | sort) | ||
|
|
||
| # endtoend tests should be in a directory called endtoend | ||
| all_e2e_tests=$(echo "$packages_with_tests" | cut -d" " -f1) |
There was a problem hiding this comment.
did you mean to filter for only endtoend here? I would expect a grep somewhere
There was a problem hiding this comment.
the path in the previous line ./go/.../endtoend/... takes care of that. I think the comment is misleading, we can fix that in another PR.
systay
approved these changes
Oct 15, 2019
|
This is important to get other PRs to pass, so I'm merging it pronto. If anyone else reviews this and finds things we should fix, let's do that in a separate PR. |
|
This is still a stop gap. As we add more tests (especially as we move python tests to go), we will need a framework to group tests so that each group fits into the 8 minute limit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endtoendande2e_racetests to config.jsonmake unit_test_racewill exclude endtoend testsmake unit_testcontinues to run all tests (this is not used by Travis CI).Also speed up backup test.
Signed-off-by: deepthi [email protected]