Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiSplitDiff support in workflow #5290

Merged
merged 1 commit into from
Oct 11, 2019
Merged

MultiSplitDiff support in workflow #5290

merged 1 commit into from
Oct 11, 2019

Conversation

lyonlai
Copy link
Collaborator

@lyonlai lyonlai commented Oct 10, 2019

  • Add MultiSplitDiff support in workflow
  • Fix issues with arguments ordering for exclude_tables & use_consistent_snapshot
  • Added skipSplitRatio check option in because use_consistent_snapshot you can use 1 Rdonly tablet to do the MultiSplitDiff.

@lyonlai lyonlai requested a review from sougou as a code owner October 10, 2019 21:26
@lyonlai lyonlai force-pushed the ylai-20191010-multi-split-diff-in-workflow branch 2 times, most recently from dac3692 to fec955c Compare October 11, 2019 00:29
@lyonlai lyonlai force-pushed the ylai-20191010-multi-split-diff-in-workflow branch from fec955c to 37c586e Compare October 11, 2019 08:39
@systay systay merged commit 0ecab46 into vitessio:master Oct 11, 2019
@spark4 spark4 mentioned this pull request Nov 12, 2019
Closed
@spark4 spark4 mentioned this pull request Nov 22, 2019
Merged
@rafael rafael mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirsen tirsen tirsen approved these changes

@sougou sougou Awaiting requested review from sougou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lyonlai @tirsen @systay