Add support for COM_RESET_CONNECTION #5219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sougou
reviewed
Sep 25, 2019
| defer atomic.AddInt32(&busyConnections, -1) | ||
| } | ||
| _, _, err := vh.vtg.Execute(ctx, session, "rollback", make(map[string]*querypb.BindVariable)) | ||
| if err != nil { |
There was a problem hiding this comment.
It's better to log the error and return success. In fact, you can have this function not return an error at all.
saifalharthi
changed the title
|
Can you rebase once the work is complete and fix the commit messages to describe what was done in each commit? The message on 683b772 is good, but the others are vague and don't tell you what is in the commit. |
Signed-off-by: Saif Alharthi <[email protected]>
saifalharthi
force-pushed
the
sa-5201
branch
from
cf89328 to
52b3b77
Compare
saifalharthi
changed the title
Signed-off-by: Saif Alharthi <[email protected]>
Signed-off-by: Saif Alharthi <[email protected]>
sougou
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Saif Alharthi [email protected]