Flaky vplayer tests: temporarily disable noblob variant #13100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
noblob
PR #12905 has introduced a race during the unit race test. This is caused by the re-initialization ofglobalDBQueries
, which we do because we run all tests twice: once for the full image and once for noblob. It turns out that the post-copy vcopier task, inTestCancelledDeferSecondaryKeys
which runs in a goroutine, gets invoked when we cancel the context before the second set of tests. Since we immediately reinit the query queue, there is a race because the post-copy task is writing to the same query queue.We will need to do a non-trivial refactor of the test framework before re-enabling the
noblob
variant. This PR temporarily disables them since the flakiness is blocking other PRsRelated Issue(s)
#13093
Checklist
Deployment Notes