Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky vplayer tests: temporarily disable noblob variant #13100

Conversation

rohit-nayak-ps
Copy link
Contributor

Description

The noblob PR #12905 has introduced a race during the unit race test. This is caused by the re-initialization of globalDBQueries, which we do because we run all tests twice: once for the full image and once for noblob. It turns out that the post-copy vcopier task, in TestCancelledDeferSecondaryKeys which runs in a goroutine, gets invoked when we cancel the context before the second set of tests. Since we immediately reinit the query queue, there is a race because the post-copy task is writing to the same query queue.

We will need to do a non-trivial refactor of the test framework before re-enabling the noblob variant. This PR temporarily disables them since the flakiness is blocking other PRs

Related Issue(s)

#13093

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

…eads from the old tests which continue to write to global queues. Need to refactor the test framework before reenabling. Temporarily disabling them since the flaky tests are affecting other PRs

Signed-off-by: Rohit Nayak <[email protected]>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented May 17, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 17, 2023
@github-actions github-actions bot added this to the v17.0.0 milestone May 17, 2023
@rohit-nayak-ps rohit-nayak-ps added Component: VReplication and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request Component: VReplication labels May 17, 2023
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review May 17, 2023 08:41
@rohit-nayak-ps rohit-nayak-ps requested a review from mattlord as a code owner May 17, 2023 08:41
@harshit-gangal harshit-gangal merged commit 44bb53d into vitessio:main May 17, 2023
@harshit-gangal harshit-gangal deleted the rn-disable-flaky-noblob-vplayer-unit-tests-temporarily branch May 17, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants