Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flakes: vreplication unit test flakiness #13093

Closed
mattlord opened this issue May 16, 2023 · 0 comments · Fixed by #13104
Closed

Flakes: vreplication unit test flakiness #13093

mattlord opened this issue May 16, 2023 · 0 comments · Fixed by #13104

Comments

@mattlord
Copy link
Contributor

mattlord commented May 16, 2023

Overview of the Issue

Some recent changes/additions to the tabletmanager's vreplication unit tests (go/vt/vttablet/tabletmanager/vreplication) surfaced a latent race condition caused by the use of global variables (most notably the globalDBQueries variable that can be used by any number of concurrent test executions). You can see examples of the failures here: https://github.com/vitessio/vitess/actions/runs/4989944133

I think that we will need to make some changes to the test framework, similar to what was done for some others in: #12546

Reproduction Steps

You will see failures if you re-run this locally enough times:

go test -count 1 -v -timeout 5m -race vitess.io/vitess/go/vt/vttablet/tabletmanager/vreplication

Binary Version

17.0.0-SNAPSHOT

Operating System and Environment details

N/A

Log Fragments

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant