Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabletThrottler: vtctlclient UpdateThrottlerConfig use VtctldServer RPC #12936

Merged
merged 1 commit into from
Apr 20, 2023
Merged

TabletThrottler: vtctlclient UpdateThrottlerConfig use VtctldServer RPC #12936

merged 1 commit into from
Apr 20, 2023

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Apr 20, 2023 •
edited by mattlord
Loading

Description

This PR brings the vtctl/vtctlclient UpdateThrottlerConfig client command behavior in line with the vtctldclient UpdateThrottlerConfig client command behavior as they are all now using the same RPC — the VtctldServer UpdateThrottlerConfig gRPC call (implementation can be seen here) — to ensure that the Keyspace record is properly updated and the changes get immediately propagated to the SrvKeyspace records.

Related Issue(s)

Fixes #12935

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach requested review from mattlord and a team April 20, 2023 05:59
@github-actions github-actions bot added this to the v17.0.0 milestone Apr 20, 2023
mattlord
mattlord approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

@shlomi-noach
Copy link
Contributor Author

Thanks!

It's your contribution, I didn't mention.

@shlomi-noach shlomi-noach requested a review from a team April 20, 2023 14:27
@mattlord mattlord changed the title vtctlclient UpdateThrottlerConfig to update Keyspace TabletThrottler: vtctlclient UpdateThrottlerConfig use VtctlServer RPC Apr 20, 2023
dbussink
dbussink approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@dbussink dbussink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much nicer!

@shlomi-noach shlomi-noach merged commit 15c0292 into vitessio:main Apr 20, 2023
@shlomi-noach shlomi-noach deleted the vtctlclient-update-throttler-config-keyspace branch April 20, 2023 15:21
@mattlord mattlord changed the title TabletThrottler: vtctlclient UpdateThrottlerConfig use VtctlServer RPC TabletThrottler: vtctlclient UpdateThrottlerConfig use VtctldServer RPC Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbussink dbussink dbussink approved these changes

@mattlord mattlord mattlord approved these changes

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: Cluster management Type: Bug
Projects
None yet
Milestone
v17.0.0
Development

Successfully merging this pull request may close these issues.

Bug Report: vtctlclient -- UpdateThrottlerConfig only updates SrvKeyspace but not Keyspace
3 participants
@shlomi-noach @dbussink @mattlord