Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: vtctlclient -- UpdateThrottlerConfig only updates SrvKeyspace but not Keyspace #12935

Closed
shlomi-noach opened this issue Apr 20, 2023 · 0 comments · Fixed by #12936

Comments

@shlomi-noach
Copy link
Contributor

Overview of the Issue

Context: #12523 and #12520

The fix in #12520 applies to vtctldclient UpdateThrottlerConfig. However, vtctldclient and vtctlclient use different code paths at this time. The fix is missing on vtctlclient. As result, vtctlclient -- UpdateThrottlerConfig does not update Keyspace's ThrottlerConfig. Users of vtctlclient are therefore still susceptible to #12523

Reproduction Steps

$ vtctlclient -- UpdateThrottlerConfig --enable --threshold 1.111 commerce
$ vtctlclient -- GetKeyspace commerce
{
  "served_froms": [],
  "keyspace_type": 0,
  "base_keyspace": "",
  "snapshot_time": null,
  "durability_policy": "semi_sync",
  "throttler_config": null,
  "sidecar_db_name": "_vt"
}

Binary Version

v16

Operating System and Environment details

-

Log Fragments

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant