Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docs/guide/static-deploy.md): adds Heroku instructions #13975

Closed
wants to merge 1 commit into from

Conversation

NdagiStanley
Copy link

Description

This PR adds Heroku instructions to the Deployment options.

Additional context

This PR removed Heroku instructions since they were outdated. This PR adds up-to-date instructions.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jul 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

Thanks for the PR @NdagiStanley. We decided to avoid expanding this guide in favor of adding links to the docs on the services. They can do a better job than us in keeping these instructions up to date. See:

Apart from this, Heroku no longer counts with a free plan so that was also in part what triggered us to remove it from our guide.

@patak-dev patak-dev closed this Jul 28, 2023
@NdagiStanley
Copy link
Author

Well noted @patak-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants