Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(static-deploy): added deployment instructions for AWS with Flightcontrol #13679

Merged
merged 1 commit into from
Jul 13, 2023
Merged

docs(static-deploy): added deployment instructions for AWS with Flightcontrol #13679

merged 1 commit into from
Jul 13, 2023

Conversation

ModupeD
Copy link
Contributor

@ModupeD ModupeD commented Jun 29, 2023

Description

This PR aims to add instructions for deploying a Vite project to AWS using Flightcontrol.

Flightcontrol provides fully automated deployments to AWS.

This is a new PR that was created as a result of the feedback given in PR one

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ModupeD
Update static-deploy.md
5990da8 
Added Flightcontrol as a deployment option
@stackblitz
Copy link

stackblitz bot commented Jun 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ModupeD ModupeD changed the title docs(static-deploy): add deployment instructions for AWS with Flightcontrol docs(static-deploy): added deployment instructions for AWS with Flightcontrol Jun 29, 2023
patak-dev
patak-dev approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ModupeD! This looks good to me.

@patak-dev patak-dev added the documentation Improvements or additions to documentation label Jul 3, 2023
@ModupeD
Copy link
Contributor Author

ModupeD commented Jul 7, 2023 •
edited
Loading

@patak-dev just wanted to remind you about this, could this be merged

@patak-dev patak-dev merged commit fd1b731 into vitejs:main Jul 13, 2023
@sapphi-red sapphi-red mentioned this pull request Jul 24, 2023
Closed
9 tasks
@patak-dev patak-dev mentioned this pull request Jul 28, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ModupeD @patak-dev @bluwy