-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add Vite 6 Environment API support #786
Open
userquin
wants to merge
7
commits into
main
Choose a base branch
from
userquin/feat-add-vite6-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-plugin-pwa-legacy ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/publish |
commit: |
userquin
added
the
do NOT merge yet
Do not merge this PR into the target branch yet
label
Nov 15, 2024
This was referenced Nov 29, 2024
Merged
userquin
changed the title
feat!: add Vite 6 support
feat!: add Vite 6 Environment API support
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
2024-11-15
: this PR only tested with VanillaJS/TypeScript viatest:vite-ecosystem-ci
script, rn cannot be tested with lib frameworks, Vite ecosystem-ci is failing forvue
andsvelte
(preparing external tests for react).Tested with:
resolve.conditions: ['browser']
)Vite or Svelte plugin resolving Svelte fromindex-server.js
insteadindex-client.js
pnpm create vite > React TS
+ adding pwa stuff frompnpm create @vite-pwa/pwa > React TS
)pnpm create vite > Vue TS
+ adding pwa stuff frompnpm create @vite-pwa/pwa > Vue TS
)Linked Issues
Additional Context
fix #798
Tip
The author of this PR can publish a preview release by commenting
/publish
below./publish