Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency error on vite 6 #800

Closed
steffchep opened this issue Nov 29, 2024 · 4 comments
Closed

dependency error on vite 6 #800

steffchep opened this issue Nov 29, 2024 · 4 comments

Comments

@steffchep
Copy link

steffchep commented Nov 29, 2024

I get this:

Could not resolve dependency:
npm error peer vite@"^3.1.0 || ^4.0.0 || ^5.0.0" from [email protected]
npm error node_modules/vite-plugin-pwa
npm error   vite-plugin-pwa@"^0.21.0" from the root project

When trying to npm install with vite 6
Workaround is to use --force or --legacy-peer-deps, but please add vite 6 :)

Edit I see there is a PR for this! 👍

@gabrielrbarbosa
Copy link
Contributor

#797

@userquin
Copy link
Member

userquin commented Nov 29, 2024

Should be fixed using this version: https://pkg.pr.new/vite-plugin-pwa@58553f8 (check last commit in the PR).

I'm going to release a new version with Vite 6 support, sorry for the delay.

@userquin
Copy link
Member

userquin commented Nov 29, 2024

I'm going to release a new patch (v0.21.1) adding vite 6 to the peers + fix build when manifest enabled via #797 PR : we're going to keep #786 (using Vite 6 Environment API) open for a while, we want to do some more tests.

EDIT: ignore this comment, this comment is for #798

@userquin userquin changed the title dependency error on vite 6 dependency error on vite 6 (using environment api PR) Nov 29, 2024
@userquin userquin changed the title dependency error on vite 6 (using environment api PR) dependency error on vite 6 Nov 29, 2024
@userquin
Copy link
Member

closed via #797

@userquin userquin reopened this Nov 29, 2024
@userquin userquin changed the title dependency error on vite 6 dependency error on vite 6 (using environment api PR) Nov 29, 2024
@userquin userquin changed the title dependency error on vite 6 (using environment api PR) dependency error on vite 6 Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants