Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uib changes for datepicker, typeahead and timepicker #443

Merged
merged 1 commit into from
Mar 24, 2016

Conversation

ckosloski
Copy link
Contributor

Updated to use Angular 1.5.0, bootstrap 3.3.6, ui-bootstrap 1.2.4.
Updated datepicker, typeahead, timepicker to use the new uib prefix.
Fixed all all but 2 broken tests (which might be related to #414).

This replaces PR #406

This should fix issues #440, #435, #428, #317

@eugef
Copy link
Collaborator

eugef commented Mar 24, 2016

@ckosloski what exactly tests are broken?

If you merge #414 would those tests still fail?

@ckosloski
Copy link
Contributor Author

@eugef All the tests were failing before. The two tests failing now are the dev-text/blur = "submit" and blur = "cancel".

I didn't test if #414 would fix it or not. I will take a look.

…dated datepicker, typeahead, timepicker to use the new uib prefix.
@ckosloski
Copy link
Contributor Author

I have merged #414 into my pull request. That change fixed the 2 broken tests.

@eugef
Copy link
Collaborator

eugef commented Mar 24, 2016

Thanks @ckosloski, great job

@lalitkapoor
Copy link

@ckosloski thank you!

@ckosloski ckosloski mentioned this pull request Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants