-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date Missing ngModel #449
Comments
I do see the uib warnings in the console when I look at your plunkr:
Try downloading the latest code and building it yourself. Pull Request #443 added support for a more recent version of ui-bootstrap that I don't think is in the release yet. |
I thought I saw it in the commits for the 1.11 release, but on a second look you're right and it's not there. I'll give building it locally a shot. |
I built the latest version of the code locally and added it to the plunkr. Which did remove the warnings, but the same errors are still occurring. I did a bit of digging and it appears to break specifically on anything past ui-bootstrap version 1.1.0. Taking a look at the commits for that release and it appears that angular-ui/bootstrap#5274 might be causing the issue. It looks like the Regardless using ui-bootstrap 1.0.3 seems to work fine until the issue is resolved. |
It does seem like something is not getting removed properly then the editable form is closed. I haven't been able to figure out what the issue is exactly. |
I think this can be fixed by adding the following to the UibDatepickerPopupController: $element.on('$destroy', function() {
$scope.$destroy();
}); I have opened an issue with ui-bootstrap |
Thanks @ckosloski! Hopefully ui-bootstrap makes that change. |
Try using the latest release (0.2.0). It looks like #489 might have fixed the issues. |
@eugef please close, this should be fixed in the latest release. |
I'm trying to use the
editable-bsdate
directive with Angular 1.5 and ui-bootstrap 1.2.4, and I'm getting a couple errors involvingngModel
.Specifically you can open up the open the
editable-bsdate
, select a value and save just fine. After the first time, every subsequent editing of the date causes errors looking for thengModel
controller.I'm not sure if this directive is somehow changing the
uib-datepicker
in such a way that the model is removed, or something else entirely.Here is a plunkr to reproduce the issue: https://plnkr.co/edit/An8NoMhdSdJ1SVIqW2Gp?
The text was updated successfully, but these errors were encountered: