-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type coercion has been deprecated. Please, use data pipes instead. #254
Comments
I also get this warning and I am unable to comprehend what I am doing wrong. |
+1, this is a rather nasty problem, as it added 4-5 ms PER item to our updates. Given that there seems to be no easy way yet to access the DataPipe constructor (at least it's not exported by vis-data, nor easily accessible therefrom), this is blocking. |
@Thomaash Can you please explain how things work with data pipes? |
Hi @rvillalba-novetta, @alebx, @anderschbe and anybody else reading this, I anticipated this issue and there is a section at the end of the docs (https://visjs.github.io/vis-data/data/datapipe.html) to help you with transition. It includes a piece of code that you can copy paste to get very similar functionality. It's not a drop in replacement though because you'll end up with uncoerced (input) and coerced (output) data sets. Regarding the constructor that is indeed not exported. It is created using a builder that you can obtain by calling PS: If you still have some questions after reading the docs feel free to mention me. |
Switch from the deprecated type property of Data Set to Data Pipes. This solves some or maybe all issues from #254. PS: There is a bug in Vis Data that prevents this from working see visjs/vis-data/pull/78.
Okay so I think I have everything figured out. I didn't realize how heavily dependent Vis Timeline is on this functionality. Once it's reviewed (hopefully there are no more issues in the PRs) everything should work fine. My previous comment applies only if you use type coersion directly (the |
It is a bug after all. |
Switch from the deprecated type property of Data Set to Data Pipes. This solves some or maybe all issues from #254. PS: There is a bug in Vis Data that prevents this from working see visjs/vis-data/pull/78.
Switch from the deprecated type property of Data Set to Data Pipes. This solves some or maybe all issues from #254. PS: There is a bug in Vis Data that prevents this from working see visjs/vis-data/pull/78.
Hey, any progress with this bug? it explodes the console with tons for warning and traces. |
6.4.0 introduced this. A fix that would solve this (#259) awaits review. It's also possible to just update Vis Data as the logging has been reduced a lot in last release. |
* fix(type-coercion): use Data Pipes Switch from the deprecated type property of Data Set to Data Pipes. This solves some or maybe all issues from #254. PS: There is a bug in Vis Data that prevents this from working see visjs/vis-data/pull/78. * docs(type-coercion): add more documentation * fix(type-coersion): prevent potential NPE
Fixed with #259 |
I'm getting the following log printing to my console whenever I update the timeline's DataSet with
dataSet.update()
I'm on the latest version of vis-timeline.
The text was updated successfully, but these errors were encountered: