fix(data-pipe): export it #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is quite a stupid error but I forgot to export it from the index.
Thomaash
added a commit
to visjs/vis-timeline
that referenced
this pull request
Jan 18, 2020
Switch from the deprecated type property of Data Set to Data Pipes. This solves some or maybe all issues from #254. PS: There is a bug in Vis Data that prevents this from working see visjs/vis-data/pull/78.
yotamberk
approved these changes
Jan 19, 2020
|
🎉 This PR is included in version 6.3.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thomaash
added a commit
to visjs/vis-timeline
that referenced
this pull request
Jan 19, 2020
Switch from the deprecated type property of Data Set to Data Pipes. This solves some or maybe all issues from #254. PS: There is a bug in Vis Data that prevents this from working see visjs/vis-data/pull/78.
Thomaash
added a commit
to visjs/vis-timeline
that referenced
this pull request
Jan 22, 2020
Switch from the deprecated type property of Data Set to Data Pipes. This solves some or maybe all issues from #254. PS: There is a bug in Vis Data that prevents this from working see visjs/vis-data/pull/78.
yotamberk
pushed a commit
to visjs/vis-timeline
that referenced
this pull request
Jan 25, 2020
* fix(type-coercion): use Data Pipes Switch from the deprecated type property of Data Set to Data Pipes. This solves some or maybe all issues from #254. PS: There is a bug in Vis Data that prevents this from working see visjs/vis-data/pull/78. * docs(type-coercion): add more documentation * fix(type-coersion): prevent potential NPE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per visjs/vis-timeline/issues/254 I noticed some issues. Like the fact that I actually forgot to export this.