Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline not loading due to 'Object expected'-error in IE11 #243

Closed
pwlinkas opened this issue Jan 8, 2020 · 4 comments · Fixed by #251
Closed

Timeline not loading due to 'Object expected'-error in IE11 #243

pwlinkas opened this issue Jan 8, 2020 · 4 comments · Fixed by #251
Labels
bug Something isn't working released

Comments

@pwlinkas
Copy link

pwlinkas commented Jan 8, 2020

Error

In IE11 I get the error Object expected on line 20 in Range.js. Looks like moment is undefined.

const now = moment().hours(0).minutes(0).seconds(0).milliseconds(0);

Steps to reproduce

  1. Open the basic example in IE11
  2. Timeline not loading due to error above

I can't find any list of supported browsers for vis-timeline, so I'm not sure if IE11 is supposed to be supported anymore.

@Async0x42
Copy link
Contributor

I haven't looked into it yet, but the latest version (6.3.5) breaks IE11 support for me. 6.3.4 seems to work in IE11.

@Thomaash
Copy link
Member

My untested theory:

  • Vis Util had IE11 issues until 2.0.1, Timeline uses 1.1.4.
  • Vis Data had IE11 issues until 6.2.4, Timeline uses 6.1.1.

With Timeline 6.3.5 prototype pollution was removed which most likely caused these issues. The pollution provided missing polyfills for these versions and since it is no longer present it just doesn't work.

Simply updating dependencies or providing global polyfills could resolve this issue.

@yotamberk yotamberk added the bug Something isn't working label Jan 12, 2020
@fras2560
Copy link
Contributor

fras2560 commented Jan 14, 2020

@Thomaash I encountered the similar issue. I updated both Vis Util and Vis Data to the recommended versions and it seemed to resolve the IE 11 issues I encountered.

Thomaash added a commit that referenced this issue Jan 14, 2020
This brings new featuer introduce in Vis Data (hence feat) and also
fixes IE11 issues.

Closes #243.
yotamberk pushed a commit that referenced this issue Jan 14, 2020
This brings new featuer introduce in Vis Data (hence feat) and also
fixes IE11 issues.

Closes #243.
@vis-bot
Copy link
Collaborator

vis-bot commented Jan 14, 2020

🎉 This issue has been resolved in version 6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants