Feature for issue #244: Attempt at configuring the long press time #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default is 251 since I beleive that is the default of hammer Added it to the documentation I had to set it at Core and ItemSet
|
Hi @fras2560, I think that @yotamberk is the best person to review this. I generally only participate in Timeline when it's about the build process or the projects I maintain (like Vis Util and Vis Data in #243). |
yotamberk
reviewed
Jan 18, 2020
lib/timeline/Core.js
Outdated
| @@ -1044,6 +1045,11 @@ class Core { | |||
| direction: contentsOverflow ? Hammer.DIRECTION_ALL : Hammer.DIRECTION_HORIZONTAL | |||
| }); | |||
|
|
|||
| // set the long press time | |||
| this.hammer.get('press').set({ | |||
| time: this.options.multiselectLongPressTime | |||
There was a problem hiding this comment.
I think you're missing default value here.
There was a problem hiding this comment.
The default value should now be set.
Did some testing against the default and 251 does seem to be the default right now
Conflicts: docs/timeline/index.html
Conflicts: docs/timeline/index.html
yotamberk
approved these changes
Jan 25, 2020
|
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default is 251 since I believe that is the default of hammer.js
Added it to the documentation
I had to set it at Core and ItemSet although there is probably a better way to achieve this.