Remove strict semvar for clap dependency #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a |
Signed-off-by: Kevin Hui <[email protected]>
Signed-off-by: Kevin Hui <[email protected]>
|
Ah, the clippy issue is coming down to the MSRV problem I addressed in the issue :\ Are you folks comfortable with upgrading this to 1.74? https://github.com/virtee/snphost/blob/main/Cargo.toml#L14 |
|
We usually try to stay in line with what major distros are using. I think an update to 1.74 (maybe even 1.8?) is fine. |
|
@larrydewey are you alright with updating? |
Signed-off-by: Kevin Hui <[email protected]>
Signed-off-by: Kevin Hui <[email protected]>
CookieComputing
force-pushed
the
main
branch
from
38c9a14 to
095d8b5
Compare
This was referenced Sep 5, 2024
|
Can we bump this to 1.80, instead?
|
tylerfanelli
requested changes
Sep 5, 2024
| @@ -11,7 +11,7 @@ readme = "README.md" | |||
| keywords = ["amd", "sev", "snp"] | |||
| categories = ["os", "os::linux-apis", "parsing", "cryptography", "hardware-support"] | |||
| exclude = [ ".gitignore", ".github/*" ] | |||
| rust-version = "1.70" | |||
| rust-version = "1.74" | |||
There was a problem hiding this comment.
Suggested change
| rust-version = "1.74" | |
| rust-version = "1.80" |
tylerfanelli
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a related note to virtee/snpguest#68, removes the strict dependency versioning on
clap