Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clap dependency restrictive semver? #68

Closed
CookieComputing opened this issue Aug 23, 2024 · 2 comments
Closed

Clap dependency restrictive semver? #68

CookieComputing opened this issue Aug 23, 2024 · 2 comments

Comments

@CookieComputing
Copy link
Contributor

Hi folks,

I was taking a look at the Cargo.toml file, and noticed the clap dependency has a rather restrictive semver constraint ("<4.5", specifically). I was wondering if there was a particular reason for this? I was surprised to see the restriction against "<4.5", when it seems like the repo would probably build fine with 4.5? I've noticed that this is also present in the snphost repo as well.

Is this for MSRV reasons? I think Clap 4.4 has an MSRV of 1.70, while Clap 4.5 has an MSRV of 1.74. However, since you folks have committed your lockfile, I think should that be sufficient in imposing a version constraint without applying modifiers on the version number. Let me know your thoughts!

@tylerfanelli
Copy link
Member

tylerfanelli commented Aug 26, 2024

@larrydewey I think you added the clap dependency in favor of structopt, was there a reason for the constraint?

@CookieComputing
Copy link
Contributor Author

Closing since #69 was checked in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants