Add nvmrc and update travis' chrome reference

.nvmrc

@@ -0,0 +1 @@
+lts/*

.travis.yml

@@ -1,8 +1,9 @@
-sudo: false
+sudo: required
 dist: trusty
 language: node_js
-node_js:
-  - 'node'
+cache:
+  directories:
+    - node_modules
 notifications:
   hipchat:
     rooms:
@@ -14,16 +15,8 @@ notifications:
 before_script:
   # always install the appropriate version of video.js for the environment
   - npm i "video.js@$VJS";
-  - export CHROME_BIN=/usr/bin/google-chrome
-  - export DISPLAY=:99.0
-  - sh -e /etc/init.d/xvfb start
 env:
   - VJS=5
   - VJS=6
 addons:
-  firefox: latest
-  apt:
-    sources:
-    - google-chrome
-    packages:
-    - google-chrome-stable
+  chrome: stable

package.json

@@ -114,9 +114,9 @@
     "isparta": "^4.0.0",
     "istanbul": "^0.4.5",
     "jsdoc": "^3.4.0",
-    "karma": "^0.13.0",
+    "karma": "^1.7.1",
     "karma-browserify": "^4.4.0",
-    "karma-chrome-launcher": "^0.2.0",
+    "karma-chrome-launcher": "^2.2.0",
     "karma-coverage": "^1.1.1",
     "karma-detect-browsers": "^2.0.0",
     "karma-firefox-launcher": "^0.1.0",
@@ -132,9 +132,9 @@
     "qunitjs": "^2.0.1",
     "serve-static": "^1.10.0",
     "shelljs": "^0.5.3",
-    "sinon": "1.10.2",
+    "sinon": "1.10.3",
     "uglify-js": "^2.5.0",
-    "videojs-contrib-quality-levels": "^2.0.2",
+    "videojs-contrib-quality-levels": "^2.0.4",
     "videojs-flash": "^2.0.0",
     "videojs-standard": "^4.0.3",
     "videojs-swf": "^5.2.0",

test/karma.conf.js

@@ -18,7 +18,7 @@ module.exports = function(config) {
   };
 
   if (process.env.TRAVIS) {
-    config.browsers = ['travisChrome'];
+    config.browsers = ['ChromeHeadlessNoSandbox'];
   }
 
   // If no browsers are specified, we enable `karma-detect-browsers`
@@ -67,8 +67,8 @@ module.exports = function(config) {
       }
     },
     customLaunchers: {
-      travisChrome: {
-        base: 'Chrome',
+      ChromeHeadlessNoSandbox: {
+        base: 'ChromeHeadless',
         flags: ['--no-sandbox']
       }
     },

test/videojs-contrib-hls.test.js

@@ -1926,15 +1926,21 @@ QUnit.test('remove event handlers on dispose', function(assert) {
   let unscoped = 0;
 
   player = createPlayer();
-  player.on = function(owner) {
-    if (typeof owner !== 'object') {
+
+  const origPlayerOn = player.on.bind(player);
+  const origPlayerOff = player.off.bind(player);
+
+  player.on = function(...args) {
+    if (typeof args[0] !== 'object') {
       unscoped++;
     }
+    origPlayerOn(...args);
   };
-  player.off = function(owner) {
-    if (typeof owner !== 'object') {
+  player.off = function(...args) {
+    if (typeof args[0] !== 'object') {
       unscoped--;
     }
+    origPlayerOff(...args);
   };
   player.src({
     src: 'manifest/master.m3u8',
@@ -1948,6 +1954,8 @@ QUnit.test('remove event handlers on dispose', function(assert) {
   this.standardXHRResponse(this.requests[0]);
   this.standardXHRResponse(this.requests[1]);
 
+  assert.ok(unscoped > 0, 'has unscoped handlers');
+
   player.dispose();
 
   assert.ok(unscoped <= 0, 'no unscoped handlers');