Add nvmrc and update travis' chrome reference #1322

gesinger · 2018-01-19T22:26:05Z

Requirements Checklist

Feature implemented / Bug fixed
If necessary, more likely in a feature request than a bug fix
- Unit Tests updated or fixed
- Docs/guides updated
- Example created (starter template on JSBin)
Reviewed by Two Core Contributors

forbesjo · 2018-01-19T22:33:24Z

You may need sudo: required

forbesjo · 2018-01-19T22:34:03Z

.travis.yml

@@ -2,7 +2,7 @@ sudo: false
 dist: trusty
 language: node_js
 node_js:
-  - 'node'
+  - lts/*


You can remove node_js: since this is already defined in the .nvmrc

…ispose

squarebracket · 2018-01-23T17:50:22Z

Not sure if these fixes will stop errors like this, but I've had sporadic disconnect errors in the past when testing. Maybe we should add browserDisconnectTolerance: 3 to the karma config?

…sion to fix clearInterval with null errors in tests

squarebracket · 2018-01-23T23:10:46Z

Wow, what a roller coaster. Hopefully you still have some hair left cuz I’d have pulled all of mine out.

gesinger · 2018-01-23T23:25:19Z

Yeah @squarebracket , it's been a fun one. Still have one test to fix, but 12/13 have been resolved. Hopefully have enough hair left for that one, but it may be close.

…ng methods

Add nvmrc and update travis' chrome reference

6f7e6b0

gesinger added the in progress label Jan 19, 2018

forbesjo reviewed Jan 19, 2018

View reviewed changes

gesinger added 4 commits January 19, 2018 17:34

Set sudo to required in travis

033f0f5

Change Karma travisChrome to ChromeHeadless

b0b4706

Update karma-chrome-launcher to ^2.2.0

cdc8b90

Update karma to ^1.7.1 and remove firefox from travis configuration

7921568

forbesjo mentioned this pull request Jan 22, 2018

enable node_modules caching on travis #1258

Closed

enable node_modules caching on travis

8167017

gesinger force-pushed the travis-changes branch from 796b46e to 8167017 Compare January 22, 2018 18:40

gesinger added 3 commits January 22, 2018 14:16

Add assertion and clock tick to test for removing event handlers on d…

9b6f84e

…ispose

Remove clock tick from event handler dispose test

f4ede61

Update videojs-contrib-quality-levels to ^2.0.4

f309368

gesinger force-pushed the travis-changes branch from a0572e5 to f309368 Compare January 22, 2018 21:27

gesinger added 11 commits January 22, 2018 17:01

Allow cleanup for subtitle loader dispose tests

53027c5

Don't reuse dispose after subtitle loader dispose tests

66d2950

Move order of player dispose in playback watcher tests

8aafbcb

Tick the clock after playback watcher tests

242886a

Tick the clock after a seek in a playback watcher test

f70fd03

Try not using I-Frame in karma config

2c0cc3d

Revert karma iframe setting and try using only VJS 6 for Travis

9777233

Try deprecated group for travis config

db4c2e1

Remove deprecated group from travis config

4ed55b4

Use ChromeHeadless locally, Chrome on Travis

0d3c5cb

Try adding back in old Chrome travis config before scripts

440c8fc

gesinger added 3 commits January 23, 2018 13:27

Try switching back to apt Chrome and disable sudo

3c5c716

Remove travis node_module cache

c19737d

Roll back karma-chrome-launcher to ^0.2.0

95b1a68

gesinger added 15 commits January 23, 2018 14:06

Roll back karma to ^0.13.0

2205387

Return VJS 5 and node_js specifier in travis config

83f7888

Return travis config to its original state and remove .nvmrc

d556d13

Fix firefox reference in travis config

5bc6460

Set video.js 6 to a known working version for travis tests

6ac3e76

Set travis version of VJS 6 to 6.2.5

d659e8e

Add browserDisconnectTolerance of 3 to karma config

401add7

Return ChromeHeadless to travis config

33c7aa3

Update video.js to 6.4.0 to test on travis

2364d71

Update video.js to 6.6.0 to test on travis

f281baa

Update video.js to 6.5.1 to test on travis

755d477

Update video.js to 6.5.0 to test on travis

4760a83

Update video.js to 6.4.0 to test on travis

e81ea7e

Revert some changes to tests for travis testing

87d2c27

Update video.js to 6.5.0 to test on travis and update sinon patch ver…

06c1bfe

…sion to fix clearInterval with null errors in tests

gesinger and others added 5 commits January 24, 2018 13:57

Fix test for event handler cleanup on dispose by calling event handli…

edfc2d3

…ng methods

Revert video.js version and karma browserDisconnectTolerance

944df17

Add .nvmrc and remove node_js section from travis config

500b2d3

Rename travisChrome to ChromeHeadlessNoSandbox

850ae1c

enable node_modules caching on travis

c0140b9

OshinKaramian approved these changes Jan 25, 2018

View reviewed changes

gesinger merged commit 5b21e02 into videojs:master Jan 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add nvmrc and update travis' chrome reference #1322

Add nvmrc and update travis' chrome reference #1322

gesinger commented Jan 19, 2018

forbesjo commented Jan 19, 2018

forbesjo Jan 19, 2018

squarebracket commented Jan 23, 2018

squarebracket commented Jan 23, 2018

gesinger commented Jan 23, 2018

Add nvmrc and update travis' chrome reference #1322

Add nvmrc and update travis' chrome reference #1322

Conversation

gesinger commented Jan 19, 2018

Requirements Checklist

forbesjo commented Jan 19, 2018

forbesjo Jan 19, 2018

Choose a reason for hiding this comment

squarebracket commented Jan 23, 2018

squarebracket commented Jan 23, 2018

gesinger commented Jan 23, 2018