Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove rule on small layout #7449

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Conversation

ipadilla4
Copy link
Contributor

Previously we introduced !important rule to override BC skin properties and fix the layout for small screens. I've done several tests in Chrome, Firefox and this is not longer needed, so we can safely remove it.

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #7449 (dc85e58) into main (fc2ce3a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7449   +/-   ##
=======================================
  Coverage   79.72%   79.72%           
=======================================
  Files         116      116           
  Lines        7296     7296           
  Branches     1754     1754           
=======================================
  Hits         5817     5817           
  Misses       1479     1479           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc2ce3a...dc85e58. Read the comment docs.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gkatsev gkatsev merged commit 1d91831 into videojs:main Sep 28, 2021
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants