feat: enable responsive controls on fullscreen #7098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
approved these changes
Mar 9, 2021
misteroneill
approved these changes
Mar 9, 2021
gkatsev
changed the title
infinite-persistence
referenced
this pull request
in lbryio/lbry-desktop
Jul 12, 2021
## Root-cause `https://github.com/videojs/video.js/pull/7098` videojs was recently upgraded. ## Change Override videojs default theme of hiding the time control in smaller layouts.
infinite-persistence
referenced
this pull request
in lbryio/lbry-desktop
Jul 12, 2021
## Root-cause `https://github.com/videojs/video.js/pull/7098` videojs was recently upgraded. ## Change Override videojs default theme of hiding the time control in smaller layouts.
tzarebczan
referenced
this pull request
in lbryio/lbry-desktop
Jul 12, 2021
## Root-cause `https://github.com/videojs/video.js/pull/7098` videojs was recently upgraded. ## Change Override videojs default theme of hiding the time control in smaller layouts.
jessopb
referenced
this pull request
in lbryio/lbry-desktop
Jul 13, 2021
## Root-cause `https://github.com/videojs/video.js/pull/7098` videojs was recently upgraded. ## Change Override videojs default theme of hiding the time control in smaller layouts.
infinite-persistence
referenced
this pull request
in lbryio/lbry-desktop
Jul 13, 2021
## Root-cause `https://github.com/videojs/video.js/pull/7098` videojs was recently upgraded. ## Change Override videojs default theme of hiding the time control in smaller layouts.
jessopb
referenced
this pull request
in lbryio/lbry-desktop
Jul 14, 2021
## Root-cause `https://github.com/videojs/video.js/pull/7098` videojs was recently upgraded. ## Change Override videojs default theme of hiding the time control in smaller layouts.
|
@gkatsev, @misteroneill we recently updated to the latest videojs version which contains this fix. However, this fix forces us to introduce the use of !important, which means we will have to do something like @infinite-persistence did here. In our case, this is not a good solution because we provide a library in which integrators can override some rules by increasing the specificity. I don't know if I missed anything and what the BC means, but I think the !important is not necessary, based on my tests. @ipadilla4, maybe a reduced test case will help to understand why the !important is so important. |
|
You're definitely right. We should look into and remove |
|
@amtins the change is in Video.js 7.15.7 |
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
Co-authored-by: Ileana Padilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A client reported that control buttons are not positioned correctly when player is full-screened and screen is small.
Currently we are excluding our responsive controls on fullscreen and changes include removing that. This solves the issue for small screens. Also added !important rule to override BC skin properties and hide controls when necessary.